[webkit-reviews] review granted: [Bug 22610] We should plant shift right immediate instructions, : [Attachment 25690] The patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 22610: We should plant shift right immediate instructions,
https://bugs.webkit.org/show_bug.cgi?id=22610

Attachment 25690: The patch
https://bugs.webkit.org/attachment.cgi?id=25690&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
> +		   __ sarl_i8r(JSImmediate::getTruncatedUInt32(value) & 0x1f,
X86::eax);

Let's put a comment here, like, "Prohibit shifting by more than 31."

r=me