[webkit-reviews] review requested: [Bug 22116] Revise manual charset alias in TextCodecICU : [Attachment 25689] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 2 16:33:14 PST 2008

Jungshik Shin <jshin at chromium.org> has asked Alexey Proskuryakov
<ap at webkit.org> for review:
Bug 22116: Revise manual charset alias in TextCodecICU

Attachment 25689: patch 

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
Revises charset alias map for TextCodecICU.
	- Uses windows-949 and windows-874 instead of windows-949-2000 and
	- Replaces 'windows874' in a couple of place with 'windows-874' (for
the canonical name)
	- Maps 'dos-874' to 'windows-874'
	- Maps 'EUC-CN' to 'GBK' and replaces it with 'GBK' when it's used as
the canonical name
	- Puts Mac encodings in a separate test char-decoding-mac.html. Rename
	  in platform/mac to xnextstep-decoding.html to avoid the name
collision in the result files.
	- Adds a JS file for common functions used by char-decoding-*.html

More information about the webkit-reviews mailing list