[webkit-reviews] review granted: [Bug 22596] Some elements don't report AXBlockQuoteLevel : [Attachment 25678] Patch to return blockquote level for all elements

[bugzilla-daemon at webkit.org]

John Sullivan <sullivan at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 22596: Some elements don't report AXBlockQuoteLevel
https://bugs.webkit.org/show_bug.cgi?id=22596

Attachment 25678: Patch to return blockquote level for all elements
https://bugs.webkit.org/attachment.cgi?id=25678&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>

> +	   if ([attributeName isEqualToString:
NSAccessibilityBlockQuoteLevelAttribute])

Our style is to not have a space between colons and parameters in ObjC method
calls. I see that the current code here is inconsistent, but it would be good
to eliminate this space in new code (at least).

> +	       return [m_object->parentObjectUnignored()->wrapper()
accessibilityAttributeValue:NSAccessibilityBlockQuoteLevelAttribute];	     
>      }

r=me, assuming you are sure that m_object and m_object->parentObjectUnignored()
are guaranteed to be non-0.