[webkit-reviews] review requested: [Bug 22492] UTF7 test cases from bug 21635 fail on some buildbots : [Attachment 25676] updated patch that works without iconv module in php

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 2 10:55:58 PST 2008


Jungshik Shin <jshin at chromium.org> has asked Darin Adler <darin at apple.com> for
review:
Bug 22492: UTF7 test cases from bug 21635 fail on some buildbots
https://bugs.webkit.org/show_bug.cgi?id=22492

Attachment 25676: updated patch that works without iconv module in php
https://bugs.webkit.org/attachment.cgi?id=25676&action=review

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
With the previous patch, tests timed out on Windows (webkit) perhaps because
php in cygwin does not have iconv module. After converting php to perl, I
realized that iconv module is not necessary at all in php, which turned out to
be the case. 
This patch is the same as the previous one except that php scripts do not have
3 iconv function calls at the beginning.


More information about the webkit-reviews mailing list