[webkit-reviews] review granted: [Bug 22586] Remove WebCore CG-specific functions from Cairo Build of WebKit (Windows) : [Attachment 25672] Patch to remove some CG-specific code from the Cairo build.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 2 09:35:21 PST 2008


Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at gmail.com>'s request for review:
Bug 22586: Remove WebCore CG-specific functions from Cairo Build of WebKit
(Windows)
https://bugs.webkit.org/show_bug.cgi?id=22586

Attachment 25672: Patch to remove some CG-specific code from the Cairo build.
https://bugs.webkit.org/attachment.cgi?id=25672&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 38897)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,15 @@
> +2008-12-01  Brent Fulgham  <bfulgham at gmail.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   WARNING: NO TEST CASES ADDED OR CHANGED

You should still reference the bug in the ChangeLog. You should also remove
this line about no tests being added, and replace it with an explanation.

r=me


More information about the webkit-reviews mailing list