[webkit-reviews] review cancelled: [Bug 13736] REGRESSION (r19811): Using the down arrow in a textarea gets "stuck" at the end of a wrapped line : [Attachment 25644] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 1 22:20:59 PST 2008


Beth Dakin <bdakin at apple.com> has cancelled Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 13736: REGRESSION (r19811): Using the down arrow in a textarea gets "stuck"
at the end of a wrapped line
https://bugs.webkit.org/show_bug.cgi?id=13736

Attachment 25644: Patch
https://bugs.webkit.org/attachment.cgi?id=25644&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
This patch addresses Dan's first two comments.

The last comment about the layout tests made me have a realization. I remember
when Darin and I were debugging this together, we realized that the selection
was actually correct before the fix. The caret was just painting in the wrong
place. So actually, these tests won't catch the bug as they are written in dump
render tree (except with pixel tests of course). And changing the tests as Dan
suggests definitely would not fix the bug. I think the best solution is to keep
these tests as they are, and unfortunately, they only mean something when the
pixel tests are run.


More information about the webkit-reviews mailing list