[webkit-reviews] review denied: [Bug 22580] canvas.setShadow should use platform-independent GraphicsContext API : [Attachment 25646] take 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 1 19:57:55 PST 2008


mitz at webkit.org has denied Tony Chang (Google) <tony at chromium.org>'s request
for review:
Bug 22580: canvas.setShadow should use platform-independent GraphicsContext API
https://bugs.webkit.org/show_bug.cgi?id=22580

Attachment 25646: take 2
https://bugs.webkit.org/attachment.cgi?id=25646&action=review

------- Additional Comments from mitz at webkit.org
CGContextSetShadowWithColor takes an offset and radius in device space, but
GraphicsContext::setShadow()'s parameters are in user space. I think this patch
will lead to the wrong behavior in transformed contexts.


More information about the webkit-reviews mailing list