[webkit-reviews] review granted: [Bug 22569] build-webkit --chromium fails on windows : [Attachment 25631] make build-webkit --chromium work on windows under cygwin

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 22569: build-webkit --chromium fails on windows
https://bugs.webkit.org/show_bug.cgi?id=22569

Attachment 25631: make build-webkit --chromium work on windows under cygwin
https://bugs.webkit.org/attachment.cgi?id=25631&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
>+    my $sconsCommand = "scons";
>+    if (isCygwin()) {
>+	  # HACK: Launch scons with Win32 python instead of CYGWIN python
>+	  # Scons + MSVC only works under Win32 python
>+	  $sconsCommand = "cmd /c 'C:\\Python26\\Scripts\\scons'";
>+    }

Please add a comment with a URL to this bug or
<http://scons.tigris.org/issues/show_bug.cgi?id=2266>.

Thanks for answering my questions, Eric!  r=me