[webkit-reviews] review granted: [Bug 20443] Certain parts of link are not clickable when there is frameset : [Attachment 23855] Updated patch incorporating feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 1 15:28:03 PST 2008


Eric Seidel <eric at webkit.org> has granted Brad Garcia <bgarcia at google.com>'s
request for review:
Bug 20443: Certain parts of link are not clickable when there is frameset
https://bugs.webkit.org/show_bug.cgi?id=20443

Attachment 23855: Updated patch incorporating feedback
https://bugs.webkit.org/attachment.cgi?id=23855&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think the test could have been better.  With both positive and negative tests
made.  (sythesized clicks which should both fail and succeed, on each side of
the resize bar).  But the change itself looks fine, at least it matches what
Darin and Hyatt asked of you.  Sorry this took over a month to get through the
review queue :(


More information about the webkit-reviews mailing list