[webkit-reviews] review denied: [Bug 22561] Enable WML Support for Windows : [Attachment 25615] Add WML files to Windows Build

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Brent Fulgham
<bfulgham at gmail.com>'s request for review:
Bug 22561: Enable WML Support for Windows
https://bugs.webkit.org/show_bug.cgi?id=22561

Attachment 25615: Add WML files to Windows Build
https://bugs.webkit.org/attachment.cgi?id=25615&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 38852)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,11 @@
> +2008-11-30  Brent Fulgham  <bfulgham at gmail.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Add WML related files to Visual Studio projects.
> +
> +	   * WebCore.vcproj/WebCore.vcproj:

You should mention the other changes you made to the vcproj file in the
ChangeLog, since the diffs are so hard to read.

> +			       
PreprocessorDefinitions="__WIN32__;ENABLE_DOM_STORAGE;ENABLE_OFFLINE_WEB_APPLIC
ATIONS;ENABLE_SVG;ENABLE_SVG_ANIMATION;ENABLE_SVG_AS_IMAGE;ENABLE_SVG_USE;ENABL
E_SVG_FOREIGN_OBJECT;ENABLE_SVG_FONTS;WEBCORE_CONTEXT_MENUS;ENABLE_VIDEO;ENABLE
_WML;ENABLE_WORKERS;ENABLE_XSLT;ENABLE_XPATH"

WML support is disabled by default for all ports right now, so I don't think we
should turn it on by default for Windows.

The added files/include paths look fine.