[webkit-reviews] review granted: [Bug 22567] HashTable needs to be made usable from multiple threads. : [Attachment 25623] Addressed comments.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 1 06:17:46 PST 2008
Alexey Proskuryakov <ap at webkit.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 22567: HashTable needs to be made usable from multiple threads.
https://bugs.webkit.org/show_bug.cgi?id=22567
Attachment 25623: Addressed comments.
https://bugs.webkit.org/attachment.cgi?id=25623&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> + Guarded with variable access with a mutex.
An extra "with" here.
> + // Don't lock the mutex here bcause it can cause deadlocks at shutdown
> + // if any thread was killed during process shutdown while holding the
mutex.
Typo: bcause.
r=me
More information about the webkit-reviews
mailing list