[webkit-reviews] review denied: [Bug 21820] Unable to enter the Tamil UNICODE Characters via Thamizha Phonetic IME : [Attachment 25564] Sixth proposed patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied 's request for review:
Bug 21820: Unable to enter the Tamil UNICODE Characters via Thamizha Phonetic
IME
https://bugs.webkit.org/show_bug.cgi?id=21820

Attachment 25564: Sixth proposed patch
https://bugs.webkit.org/attachment.cgi?id=25564&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Please don't forget to set review? flag.

I tested this change, and it doesn't work sufficiently well yet. Here are the
issues I encountered in my testing:

1) Undo is broken. Steps to reproduce:
 - open the test in Safari,
 - press Backspace,
 - press Cmd+Z for Undo.
Results: instead of the combining character being brought back, the first
character is deleted, too.
It is quite clear why this happens: the delete operation can not be simply
replaced with a delete/re-add pair.

2) Deleting still doesn't work correctly after moving the caret. Steps to
reproduce:
 - open the test in Safari,
 - press Left arrow,
 - press Right arrow,
 - press Backspace.
Results: the whole ligature is deleted.

3) The automated test doesn't pass on Mac OS X. First, I'm getting EDITING
DELEGATE lines that are not in this patch (I'm surprised that you didn't have
them on Windows). Second, font metrics are different, so box sizes don't match.
For this second problem, you could consider making the test text-only.

When problems (1) and (2) are fixed, we'll need automated tests for them, as
well.