[webkit-reviews] review denied: [Bug 16171] [CAIRO] Canvas does not support globalAlpha : [Attachment 23090] Canvas globalAlpha

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Dirk Schulze <vbs85 at gmx.de>'s request
for review:
Bug 16171: [CAIRO] Canvas does not support globalAlpha
https://bugs.webkit.org/show_bug.cgi?id=16171

Attachment 23090: Canvas globalAlpha
https://bugs.webkit.org/attachment.cgi?id=23090&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
+static inline void setColor(cairo_t* cr, const Color& col, float globalAlpha)
Perhaps globalAlpha should default to 1.0f so that lines like 
+    setColor(cr, col, 1);
don't have to change. 

+    if (globalAlpha <= 0.999)
+	 alpha *= globalAlpha;

Why not just if (globalAlpha < 1.0) ?

+	 if (m_data->globalAlpha <= 0.999) {

same question.

+	 :  cr(0),
+	 globalAlpha(1)

This should read as
    GraphicsContextPlatformPrivate()
	: cr(0),
	, globalAlpha(1.0f)