[webkit-reviews] review denied: [Bug 20277] implement window.scrollByPages and window.scrollByLines : [Attachment 23055] patch v2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied arno. <arenevier at fdn.fr>'s request for
review:
Bug 20277: implement window.scrollByPages and window.scrollByLines
https://bugs.webkit.org/show_bug.cgi?id=20277

Attachment 23055: patch v2
https://bugs.webkit.org/attachment.cgi?id=23055&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
 822	 Document* doc = m_frame->document();
 823	 ASSERT(doc);
 824	 if (doc)
 825	     doc->updateLayoutIgnorePendingStylesheets();

This part of the code also belongs inside FrameView.

I'm going to say review- so you can move that code at a minimum. But also,
please investigate making the platforms share the same logic moving by line and
page by keyboard as for these functions.

For example, the current definition of how far to scroll by a line or page on
Mac OS X is in the WebFrameView class in the methods
_verticalKeyboardScrollDistance and _verticalPageScrollDistance. That's the
same distance scrollByLines and scrollByPages should use.

Maybe we do want to delegate this question to the client, because it does seem
that the Mac OS X methods are doing things that are specific to the platform.