[webkit-reviews] review requested: [Bug 20571] Window object missing Animation/Transition event setter : [Attachment 23078] patch with testcases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 29 19:07:07 PDT 2008

Dean Jackson <dino at apple.com> has asked Dave Hyatt <hyatt at apple.com> for
Bug 20571: Window object missing Animation/Transition event setter

Attachment 23078: patch with testcases

------- Additional Comments from Dean Jackson <dino at apple.com>
This patch also includes a code cleanup since a lot of this file violated the
coding guidelines and hence offended my eyes. Check the next comment for the
"real" patch.

Also, not all the tests included here are directly relevant to the fix in the
patch, but are the tests that should have been landed with the events in the
first place.

Lastly, there is an outstanding bug that makes using window pretty annoying.
The event dispatch code only fires a transition event if the document was
notified of a listener. If you attach only to Window then the Document doesn't
know, and hence nothing happens. I'll file a separate bug on that. The
workaround is to attach a transition event listener anywhere on the document
(even if it isn't in the right place and is empty).

More information about the webkit-reviews mailing list