[webkit-reviews] review denied: [Bug 20474] Canvas fillStyle() and srokeStyle() needs fallback : [Attachment 23057] Canvas invalid styles

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 28 13:05:27 PDT 2008

Eric Seidel <eric at webkit.org> has denied Dirk Schulze <vbs85 at gmx.de>'s request
for review:
Bug 20474: Canvas fillStyle() and srokeStyle() needs fallback

Attachment 23057: Canvas invalid styles

------- Additional Comments from Eric Seidel <eric at webkit.org>
The gradient and pattern if's aren't necessary.  We shouldn't be ever applying
with a NULL gradient or pattern.

Otherwise this looks great!  Nice use of the js tests!

If you were a commiter I would just r+ this and you could fix it as you commit,
as is, you should upload a new patch so it's easier for someone else to land.

More information about the webkit-reviews mailing list