[webkit-reviews] review denied: [Bug 20511] Remove static initializers on Windows (StaticConstructors.h) : [Attachment 23051] HIDE -> SKIP, English fixes in comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 28 09:33:03 PDT 2008


Darin Adler <darin at apple.com> has denied danceoffwithyourpantsoff
<danceoffwithyourpantsoff at gmail.com>'s request for review:
Bug 20511: Remove static initializers on Windows (StaticConstructors.h)
https://bugs.webkit.org/show_bug.cgi?id=20511

Attachment 23051: HIDE -> SKIP, English fixes in comments.
https://bugs.webkit.org/attachment.cgi?id=23051&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Great!

Looks fine; we can make slight refinements to the macros later, but this is
excellent. All we need now is a ChangeLog and it's ready to go.

review- because I don't want the committer to have to write the ChangeLog entry
-- please include it in the final patch.


More information about the webkit-reviews mailing list