[webkit-reviews] review requested: [Bug 20469] Close leak of PausedTimeouts, and clean up ownership : [Attachment 23052] Updated patch with darin's suggested changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 28 04:20:52 PDT 2008


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 20469: Close leak of PausedTimeouts, and clean up ownership
https://bugs.webkit.org/show_bug.cgi?id=20469

Attachment 23052: Updated patch with darin's suggested changes
https://bugs.webkit.org/attachment.cgi?id=23052&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/ChangeLog			  |   35 ++++++++++++++++++++++++++++++
 WebCore/bindings/js/JSDOMWindowBase.cpp  |   21 +++++++++--------
 WebCore/bindings/js/JSDOMWindowBase.h	  |    5 ++-
 WebCore/bindings/js/ScriptController.cpp |   22 ++++++++++++++++++
 WebCore/bindings/js/ScriptController.h   |    3 ++
 WebCore/history/CachedPage.cpp 	  |    4 +-
 WebCore/page/Chrome.cpp		  |   26 ++++++++-------------
 WebCore/page/JavaScriptDebugServer.cpp   |   14 ++++++++---
 8 files changed, 96 insertions(+), 34 deletions(-)


More information about the webkit-reviews mailing list