[webkit-reviews] review granted: [Bug 20552] CSSRule.idl missing keyframe-related RuleTypes : [Attachment 23046] Patch, testcase, changelog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 27 17:42:36 PDT 2008

Eric Seidel <eric at webkit.org> has granted Simon Fraser
<simon.fraser at apple.com>'s request for review:
Bug 20552: CSSRule.idl missing keyframe-related RuleTypes

Attachment 23046: Patch, testcase, changelog

------- Additional Comments from Eric Seidel <eric at webkit.org>
This really should be using the newer js-style tests, which have "shouldBe"
functions provided for you to produce nice "PASS" "FAIL" output for subtests
like this.  I would encourage you to look at the tests in fast/js or ask ggaren
for more infos.   make-js-test-wrappers is part of that whole system and turns
the .js files + resources/TEMPLATE.html into the resuling browser-runnable test

Change looks fine though.

More information about the webkit-reviews mailing list