[webkit-reviews] review denied: [Bug 19528] [GTK] BackForward history leak? : [Attachment 22678] Refactor WebKitWebBackForwardList and leak fixes

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 19528: [GTK] BackForward history leak?
https://bugs.webkit.org/show_bug.cgi?id=19528

Attachment 22678: Refactor WebKitWebBackForwardList and leak fixes
https://bugs.webkit.org/attachment.cgi?id=22678&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
I would encourage you to read:
http://webkit.org/coding/RefPtr.html

Methods shouldn't return RefPtr.  Possibly "const RefPtr&" , but in that case
"Class*" is almost always better.

We also don't keep PassRefPtrs on the stack.  If you need more clarification
about RefPtr design, I encourage you to read that document or ask in #webkit. 
(or read some of hte other gtk bugs I've recently reviewed).