[webkit-reviews] review granted: [Bug 19855] [GTK] Track sub frame life cycle : [Attachment 22042] Add signals to track the life cycle of sub frames
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 27 16:00:44 PDT 2008
Eric Seidel <eric at webkit.org> has granted Marco Barisione
<marco.barisione at collabora.co.uk>'s request for review:
Bug 19855: [GTK] Track sub frame life cycle
https://bugs.webkit.org/show_bug.cgi?id=19855
Attachment 22042: Add signals to track the life cycle of sub frames
https://bugs.webkit.org/attachment.cgi?id=22042&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks sane enough to me. But I sure can't claim to be a Gtk expert.
300 WebKitWebView *webView = getViewFromFrame(webFrame());
has the * in the wrong place.
If this needs a more gtk-specific review, you'll need to ask Alp or another
WebKitGtk contributer.
More information about the webkit-reviews
mailing list