[webkit-reviews] review requested: [Bug 20373] GraphicsContext needs to support Gradients and Patterns (to let us get rid of #ifdefs) : [Attachment 23023] Add stroke/fill Gradient and Pattern support to GraphicsContext and update <canvas> to use it.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 20373: GraphicsContext needs to support Gradients and Patterns (to let us
get rid of #ifdefs)
https://bugs.webkit.org/show_bug.cgi?id=20373

Attachment 23023: Add stroke/fill Gradient and Pattern support to
GraphicsContext and update <canvas> to use it.
https://bugs.webkit.org/attachment.cgi?id=23023&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/WebCore.xcodeproj/project.pbxproj	    |	 4 +
 .../js/JSCanvasRenderingContext2DCustom.cpp	    |	 4 +-
 WebCore/css/CSSGradientValue.cpp		    |	10 +-
 WebCore/css/CSSGradientValue.h 		    |	 2 +-
 WebCore/html/CanvasGradient.cpp		    |	 4 +-
 WebCore/html/CanvasGradient.h			    |	 8 +-
 WebCore/html/CanvasPattern.cpp 		    |	 2 +-
 WebCore/html/CanvasPattern.h			    |	 6 +-
 WebCore/html/CanvasRenderingContext2D.cpp	    |  196 +-------------------
 WebCore/html/CanvasRenderingContext2D.h	    |	 6 -
 WebCore/html/CanvasStyle.cpp			    |	 7 +
 WebCore/html/CanvasStyle.h			    |	 3 +-
 WebCore/platform/graphics/GeneratedImage.h	    |	10 +-
 WebCore/platform/graphics/Generator.h		    |	 4 +-
 WebCore/platform/graphics/Gradient.h		    |	16 ++-
 WebCore/platform/graphics/GraphicsContext.cpp	    |	68 ++++++-
 WebCore/platform/graphics/GraphicsContext.h	    |	39 +++--
 WebCore/platform/graphics/GraphicsContextPrivate.h |	33 +++-
 WebCore/platform/graphics/GraphicsTypes.h	    |	 2 +-
 WebCore/platform/graphics/Path.h		    |	 8 +-
 WebCore/platform/graphics/Pattern.h		    |	15 +-
 .../graphics/cairo/GraphicsContextCairo.cpp	    |	17 ++-
 WebCore/platform/graphics/cg/GraphicsContextCG.cpp |  173 ++++++++++++++---
 WebCore/platform/graphics/qt/GraphicsContextQt.cpp |	28 ++--
 WebCore/platform/graphics/wx/GraphicsContextWx.cpp |	16 +-
 25 files changed, 366 insertions(+), 315 deletions(-)