[webkit-reviews] review denied: [Bug 20531] make alternativeFamilyName platform-dependent : [Attachment 23010] patch (layout testing yet missing)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 26 17:53:43 PDT 2008

Eric Seidel <eric at webkit.org> has denied 's request for review:
Bug 20531: make alternativeFamilyName platform-dependent

Attachment 23010: patch (layout testing yet missing)

------- Additional Comments from Eric Seidel <eric at webkit.org>
Hum... it seems instead of copying this function to each platform, there should
just be a shared function which platforms can choose to call or not?  I assume
part of this is that you're suggesting that some platforms don't want these

Or maybe this should just be a case-ignoring HashMap:

HashMap<AtomicString, AtomicString, CaseFoldingHash>

Then the "default" alternateFamilyName hash can be provided by a private
function on FontCache (in FontCache.cpp) and platforms can provide their own
alternateFamilyName implementation which either does a lookup in this provided
HashMap, or modifies the HashMap, or just does their own lookup disregarding
the HashMap.

More information about the webkit-reviews mailing list