[webkit-reviews] review denied: [Bug 20393] Add WML support to WebKit : [Attachment 22955] Patch to implement WML

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 25 20:48:08 PDT 2008

Eric Seidel <eric at webkit.org> has denied George Staikos <staikos at kde.org>'s
request for review:
Bug 20393: Add WML support to WebKit

Attachment 22955: Patch to implement WML

------- Additional Comments from Eric Seidel <eric at webkit.org>
Thank you very much for the patch George!  Unfortunately it's really
unreviewable as-is.  We can't by-pass the normal review mechanisms even for a
change off-by default.	However, we can certainly land this in pieces.	Even
landing the individual new files w/o them being compiled in or being able to

There are really two questions here:
1.  Does WebKit.org want WML support?  I haven't heard any complaints against
such (and I'm myself not against adding WML support.).

2.  Is this patch OK?

The answer to the second is "it might be", but we'll be able to tell better
when split into smaller pieces which can be individually reviewed and landed
(even if not built or tested initially).

Thanks again for the patch, but I'm going to mark this large one as r-.  I look
forward to reviewing this in pieces.

More information about the webkit-reviews mailing list