[webkit-reviews] review requested: [Bug 3591] Frames only use integers as its length : [Attachment 22939] Updated patch incorporating feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 22 10:07:51 PDT 2008


Brad Garcia <bgarcia at google.com> has asked  for review:
Bug 3591: Frames only use integers as its length
https://bugs.webkit.org/show_bug.cgi?id=3591

Attachment 22939: Updated patch incorporating feedback
https://bugs.webkit.org/attachment.cgi?id=22939&action=edit

------- Additional Comments from Brad Garcia <bgarcia at google.com>
Thanks for the feedback, Eric.

I've punted on the fancier test for now.  I kept having issues with trying to
manipulate the contents of the iframe before it was loaded.  I actually got
things to update correctly from within a setTimeout, but then I don't believe
the test results get reported correctly.  So I went back to the simple test &
included the expected results this time.


More information about the webkit-reviews mailing list