[webkit-reviews] review requested: [Bug 20397] Invalid webkit-border-bottom-left-radius property causes crash : [Attachment 22928] Possible fix for bug 20397

[bugzilla-daemon at webkit.org]

Glenn Wilson <wilsong at gmail.com> has asked  for review:
Bug 20397: Invalid webkit-border-bottom-left-radius property causes crash
https://bugs.webkit.org/show_bug.cgi?id=20397

Attachment 22928: Possible fix for bug 20397
https://bugs.webkit.org/attachment.cgi?id=22928&action=edit

------- Additional Comments from Glenn Wilson <wilsong at gmail.com>
Aha...I see that I was attacking the symptom, and not the problem....and poorly
at that :(

Here's a patch that should conform to style guidelines, includes changeLog
entries, and has a layout test as well.  Please let me know if I missed
anything.

This patch merely moves the call to checkForOrphanedUnits() earlier in the
method.  The work that is done between num being set and the old call to
checkForOrphanedUnits doesn't seem to conflict with the move.  

(The case that the orphaned unit identifier is somehow paired with the keywords
"inherit" or "initial" -- this doesn't seem to be a problem because to do so
would mean multiple items in m_valueList, but both cases return when there is
more than one item in m_valueList)