[webkit-reviews] review granted: [Bug 19964] divide by zero crash in RenderBox::calculateBackgroundSize with 0, 0 bmp background image : [Attachment 22681] New patch for bug 19964

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 21 17:45:21 PDT 2008


Darin Adler <darin at apple.com> has granted Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 19964: divide by zero crash in RenderBox::calculateBackgroundSize with 0,0
bmp background image
https://bugs.webkit.org/show_bug.cgi?id=19964

Attachment 22681: New patch for bug 19964
https://bugs.webkit.org/attachment.cgi?id=22681&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	 * ChangeLog:

The ChangeLog itself shouldn't be listed in the ChangeLog.

We need a ChangeLog for the LayoutTests directory too, not just WebCore.

Otherwise this patch looks good. I'm going to say review+ but having no patch
for LayoutTests does add work for whoever commits the patch.


More information about the webkit-reviews mailing list