[webkit-reviews] review granted: [Bug 15360] color:#{predefined colorName} is okay in Safari : [Attachment 22925] Potential fix to bug 15360 with no tabs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 21 16:18:52 PDT 2008

Eric Seidel <eric at webkit.org> has granted Glenn Wilson <wilsong at gmail.com>'s
request for review:
Bug 15360: color:#{predefined colorName} is okay in Safari

Attachment 22925: Potential fix to bug 15360 with no tabs

------- Additional Comments from Eric Seidel <eric at webkit.org>
The change looks fine.	The test could still be "better"

<p id="test" style="color:#red">FAIL - testing that #color is ignored as a
color name, bug 15360</p>
if (window.layoutTestController)
var test = document.getElementById("test");
if (window.getComputedStyle(test).color == "rgb(0,0,0)") {
    test.innerText = "PASS";

would be more concise.	and shows only PASS/FAIL (to make it hopefully easier
to understand at a glance.

Even better would be to use a .js test, but that's a bit trickier for your
first patch (due to our lack of documentation on the subject, fast/js/resources
has a bunch of examples, make-js-test-wrappers is the script which generates
the .html files to run the .js tests from the TEMPLATE.html files).  We'll talk
about .js tests some time over IRC. :)

This is fine to land as-is though.

More information about the webkit-reviews mailing list