[webkit-reviews] review requested: [Bug 18703] changing the 'size' property on a text input does not affect its length : [Attachment 22922] Improved possible fix for bug 18703

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 21 11:41:22 PDT 2008


Glenn Wilson <wilsong at gmail.com> has asked  for review:
Bug 18703: changing the 'size' property on a text input does not affect its
length
https://bugs.webkit.org/show_bug.cgi?id=18703

Attachment 22922: Improved possible fix for bug 18703
https://bugs.webkit.org/attachment.cgi?id=22922&action=edit

------- Additional Comments from Glenn Wilson <wilsong at gmail.com>
Oops -- sorry about that.  Although I could blame my IDE, not remembering to
use spaces instead of tabs is probably my own fault.

Here is an improved potential patch.  Tabs have been replaced with spaces, and
a newline has been added to the end of the layout test.

I tried using setChanged() instead of requesting the renderer repaint the
element, but it didn't seem to have any effect.  Also using
setValueMatchesRenderer(false) doesn't have any effect either.	What's the
right way to let the renderer know to do this?


More information about the webkit-reviews mailing list