[webkit-reviews] review denied: [Bug 20466] Editing a property without quotes should add them if possible : [Attachment 22902] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 20 15:26:30 PDT 2008


Timothy Hatcher <timothy at hatcher.name> has denied Anthony Ricaud
<rik24d at gmail.com>'s request for review:
Bug 20466: Editing a property without quotes should add them if possible
https://bugs.webkit.org/show_bug.cgi?id=20466

Attachment 22902: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=22902&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
+	     var result =
WebInspector.panels.scripts.evaluateInSelectedCallFrame(expression, false);
+	 else
+	     var result =
InspectorController.inspectedWindow().eval(expression);
+	 return result;

no need to store in a variable, just return in the two places.

+	     var result = this.evaluateExpression("(" + expression + ")");
	     // Store the result in the property.
	     this.parentObject[this.propertyName] = result;

Put a empty line between the var result and the comment.

+		 var result = this.evaluateExpression('"' + expression + '"');
+		 // Store the result in the property.
+		 this.parentObject[this.propertyName] = result;

You should escape double quotes in the expression, otherwise it will fail
unexpectedly. Also put a empty line between the var result and the comment.

r- for now until the string is escaped. Just do
expression.escapeCharacters("\"");


More information about the webkit-reviews mailing list