[webkit-reviews] review denied: [Bug 19991] WebKit needs cross-platform filter system : [Attachment 22846] Updated Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 18 23:56:07 PDT 2008

Oliver Hunt <oliver at apple.com> has denied 's request for review:
Bug 19991: WebKit needs cross-platform filter system

Attachment 22846: Updated Patch

------- Additional Comments from Oliver Hunt <oliver at apple.com>
getFilterById is returning a bogus pointer, as ownership is not taken, so the
passrefptr will delete the object.

Various implementations of apply(ImageBuffer*) name the parameter, but don't
use it, which will result in a compile error on windows at least.

I want eric to look at the SVGResourceFilter stuff as it doesn't look correct
to me as it currently stands, but i don't know what should be happening so
can't make any suggestion as to what you should do.

More information about the webkit-reviews mailing list