[webkit-reviews] review granted: [Bug 20416] Made room for a free word in JSCell : [Attachment 22840] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 17 09:57:58 PDT 2008

Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has granted 's request for
Bug 20416: Made room for a free word in JSCell

Attachment 22840: patch

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
It seems to be our style for member variables of *Data structs to not have an
"m_" prefix, so you should do that for JSCallbackObjectData, ArgumentsData,
RegExpObjectData, and JSDOMWindowBaseData, unless we somehow reach an agreement
that the existing style should be changed. There is also a stray WebCore
xcodeproj change, although that seems to happen whenever you open it with the
new version, so someone should check it in for all the projects.

Other than that, r=me.

More information about the webkit-reviews mailing list