[webkit-reviews] review granted: [Bug 20350] [GTK] Get DumpRenderTree working : [Attachment 22835] DRT fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 17 06:16:05 PDT 2008

Holger Freyther <freyther at handhelds.org> has granted Alp Toker
<alp at nuanti.com>'s request for review:
Bug 20350: [GTK] Get DumpRenderTree working

Attachment 22835: DRT fixes

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
Great step ahead.

You should get various new unused parameter warnings, e.g. just omit the
parameter name and you are fine.

The flushing should fix quite some issues.

The cosmetic changes are I fine and besides personal taste I could not find
anything in the Coding Style Guidelines to forbid comments at the end of the

The removal of WorkQueue::shared()->clear() and addition of
webkit_web_view_open is something the other DRTs don't do. You are definitely
right that some results depend on the order of the tests...

More information about the webkit-reviews mailing list