[webkit-reviews] review denied: [Bug 19156] Inspector should support console.dirXML : [Attachment 22832] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 16 21:22:41 PDT 2008

Timothy Hatcher <timothy at hatcher.name> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 19156: Inspector should support console.dirXML

Attachment 22832: proposed patch

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Too much coped code. We need to share this with the Element's DOM more. But the
approach seems good!

I propose to factor out the TreeOutline code from ElementsPanel.js into a new
file and make it a TreeOutline subclass, like ElementsTreeOutline or
NodeTreeOutline. Then you might not need the ConsoleElementsInspector, since
that class is very small I don't see the need,

Also Firebug shows the element that was passed , not just the children. So you
need to show the body in your example.

For the record, I hate the "dir" names...

More information about the webkit-reviews mailing list