[webkit-reviews] review denied: [Bug 19155] Inspector should support console.dir : [Attachment 22811] ObjectPropertiesSection

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 15 06:21:29 PDT 2008

Timothy Hatcher <timothy at hatcher.name> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 19155: Inspector should support console.dir

Attachment 22811: ObjectPropertiesSection

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
The __lookupGetter__ change is wrong.

You need to quote the property name in braket notation.

Otherwise you are looking for a property who's name is "[Function]" or whatever
the toString result for window.__lookupGetter__ is.

Also explain why you made the change in the ChangeLog.

More information about the webkit-reviews mailing list