[webkit-reviews] review denied: [Bug 20013] Windows AX huerusitics are poor : [Attachment 22585] Updated patch to populate Name attribute properly.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 14 00:19:36 PDT 2008
Jon Honeycutt <jhoneycutt at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 20013: Windows AX huerusitics are poor
https://bugs.webkit.org/show_bug.cgi?id=20013
Attachment 22585: Updated patch to populate Name attribute properly.
https://bugs.webkit.org/attachment.cgi?id=22585&action=edit
------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
+ virtual const AccessibilityChildrenVector& children() const{ return
m_children; }
Missing space between const and {.
These changes look good, but as they fix three different, unrelated object
types, I think they should be split up: a patch to fix links and headings, a
patch for images, and a patch for text objects.
r- for this reason, but otherwise looks good, thanks!
More information about the webkit-reviews
mailing list