[webkit-reviews] review granted: [Bug 20372] HTML/SVGScriptElement need to share code : [Attachment 22784] Patch 1/2 - v2: Refactor HTMLScriptElement code in common base class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 13 19:00:42 PDT 2008


Eric Seidel <eric at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 20372: HTML/SVGScriptElement need to share code
https://bugs.webkit.org/show_bug.cgi?id=20372

Attachment 22784: Patch 1/2 - v2: Refactor HTMLScriptElement code in common
base class
https://bugs.webkit.org/attachment.cgi?id=22784&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
We talked a bit over IRC.

I don't really like the name "ScriptElementData", and I'm not sure that
"ScriptElement" shoudl be called an Element since it's not...

But I don't really have better suggestions for either name, so r=me.

Looking forward to part 2!


More information about the webkit-reviews mailing list