[webkit-reviews] review granted: [Bug 20351] <canvas> code needs fewer #ifdefs : [Attachment 22764] The final changes needed for Pattern cleanup
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 13 15:06:50 PDT 2008
Nikolas Zimmermann <zimmermann at kde.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 20351: <canvas> code needs fewer #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=20351
Attachment 22764: The final changes needed for Pattern cleanup
https://bugs.webkit.org/attachment.cgi?id=22764&action=edit
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Nice work Eric! Some comments:
No ChangeLog?
FrameLoader.cpp - change looks unrelated (style cleanup)
PatternQt.cpp missing (would break Qt build)
Other than that, r=me.
More information about the webkit-reviews
mailing list