[webkit-reviews] review granted: [Bug 14282] Cannot change the height of the docked Web Inspector : [Attachment 22767] Proposed patch

[bugzilla-daemon at webkit.org]

Kevin McCullough <kmccullough at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 14282: Cannot change the height of the docked Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=14282

Attachment 22767: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=22767&action=edit

------- Additional Comments from Kevin McCullough <kmccullough at apple.com>
InspectorController.cpp:
on line 51 do you need to specify the name of the input parameter?

On line 1367 I don't think you need to specify that setAttachedWindowHeight is
in the WebCore namespace

InspectorController.h:
Line 122.  Don't need "height" again

inspector.js:
Line 585: I don't understand the logic in toolbarDragStart.

Also please file a bug to implement setAttachedWindowHeight in
InsepctorClientWx.cpp