[webkit-reviews] review granted: [Bug 20263] [XBL] Add loading code for XBLBinding : [Attachment 22758] Same as previously with a correction for 2 small mistakes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 12 17:12:26 PDT 2008


Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 20263: [XBL] Add loading code for XBLBinding
https://bugs.webkit.org/show_bug.cgi?id=20263

Attachment 22758: Same as previously with a correction for 2 small mistakes
https://bugs.webkit.org/attachment.cgi?id=22758&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
+    int hasFragment = uri.find('#');

should probably be called fragmentOffset

This should be < 0:
(hasFragment != -1)


Sounds like we need a test case!
+    // FIXME: if no ID was given, the spec does not say what to do so for the
moment
+    // do nothing for now.

There is a deleteAllValues() call you should use instead:
+	 for (Vector<XBLBinding*>::iterator it = elementBindings->begin(); it
!= elementBindings->end(); ++it)
+	     delete *it;

Otherwise looks OK to land with the above mentioned test case.	 I don't need
to see this again, but you should make the above fixes/additional test case.


More information about the webkit-reviews mailing list