[webkit-reviews] review requested: [Bug 20351] <canvas> code needs fewer #ifdefs : [Attachment 22756] Fifth pass, try to fix the non-mac builds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 12 15:11:17 PDT 2008


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 20351: <canvas> code needs fewer #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=20351

Attachment 22756: Fifth pass, try to fix the non-mac builds
https://bugs.webkit.org/attachment.cgi?id=22756&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/GNUmakefile.am 			    |	 3 +
 WebCore/WebCore.pro				    |	 2 +
 WebCore/WebCore.vcproj/WebCore.vcproj		    |	28 ++++
 WebCore/WebCore.xcodeproj/project.pbxproj	    |	19 ++-
 WebCore/WebCoreSources.bkl			    |	 1 +
 WebCore/editing/DeleteButtonController.cpp	    |	10 +-
 WebCore/html/CanvasPattern.cpp 		    |  156 +------------------
 WebCore/html/CanvasPattern.h			    |	58 +------
 WebCore/html/CanvasRenderingContext2D.cpp	    |  116 ++++-----------
 WebCore/html/CanvasRenderingContext2D.h	    |	 4 +-
 WebCore/html/CanvasStyle.cpp			    |  165 ++++----------------
 WebCore/html/HTMLCanvasElement.cpp		    |	44 -----
 WebCore/html/HTMLCanvasElement.h		    |	24 +---
 WebCore/loader/CachedImage.cpp 		    |	24 ++--
 WebCore/loader/CachedImage.h			    |	 2 +-
 WebCore/loader/FrameLoader.cpp 		    |	 6 +-
 WebCore/loader/icon/IconRecord.cpp		    |	 6 +-
 WebCore/loader/icon/IconRecord.h		    |	 2 +-
 WebCore/platform/graphics/BitmapImage.h	    |	17 ++-
 WebCore/platform/graphics/Color.cpp		    |	10 ++
 WebCore/platform/graphics/Color.h		    |	 5 +
 WebCore/platform/graphics/GeneratedImage.h	    |	 4 +
 WebCore/platform/graphics/Gradient.cpp 	    |	 2 +-
 WebCore/platform/graphics/Gradient.h		    |	 5 -
 WebCore/platform/graphics/GraphicsContext.h	    |	 6 +-
 WebCore/platform/graphics/Image.cpp		    |	 7 +
 WebCore/platform/graphics/Image.h		    |	20 ++--
 WebCore/platform/graphics/ImageBuffer.h	    |	39 +-----
 WebCore/platform/graphics/Pattern.cpp		    |	46 ++++++
 WebCore/platform/graphics/Pattern.h		    |	66 ++++++++
 .../graphics/cairo/GraphicsContextCairo.cpp	    |	17 ++
 .../platform/graphics/cairo/ImageBufferCairo.cpp   |	 8 +-
 WebCore/platform/graphics/cairo/PatternCairo.cpp   |	46 ++++++
 WebCore/platform/graphics/cg/GraphicsContextCG.cpp |	33 ++++-
 WebCore/platform/graphics/cg/ImageBufferCG.cpp     |	 8 +-
 WebCore/platform/graphics/cg/PDFDocumentImage.h    |	11 ++-
 WebCore/platform/graphics/cg/PatternCG.cpp	    |	77 +++++++++
 WebCore/platform/graphics/gtk/ImageGtk.cpp	    |	 9 +-
 WebCore/platform/graphics/mac/ImageMac.mm	    |	12 +-
 WebCore/platform/graphics/qt/PatternQt.cpp	    |	41 +++++
 WebCore/rendering/RenderImage.cpp		    |	 3 +-
 WebCore/rendering/RenderLayer.cpp		    |	 4 +-
 WebCore/svg/graphics/SVGImage.cpp		    |	11 +--
 WebCore/svg/graphics/SVGImage.h		    |	11 ++-
 .../graphics/cairo/SVGPaintServerPatternCairo.cpp  |	 4 +-
 .../svg/graphics/cairo/SVGResourceMaskerCairo.cpp  |	 8 +-
 .../svg/graphics/cg/SVGPaintServerPatternCg.cpp    |	 2 +-
 WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm     |	 2 +-
 48 files changed, 579 insertions(+), 625 deletions(-)


More information about the webkit-reviews mailing list