[webkit-reviews] review denied: [Bug 19578] [CURL] problem in parseDataUrl : [Attachment 22628] fix the base64 problem ( using fastMalloc/fastFree )

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 12 14:30:43 PDT 2008

Holger Freyther <freyther at handhelds.org> has denied Mario Bensi
<mbensi at pleyo.com>'s request for review:
Bug 19578: [CURL] problem in parseDataUrl

Attachment 22628: fix the base64 problem ( using fastMalloc/fastFree )

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
Thanks for the patch. The for loop needs some more spaces to comply with our
Coding Style Guidelines and I wonder why memcpy can not be used?

I also wonder what problem is getting fixed? Vector<char> out is a temporary
variable, and String(out.data(), out.size()) will make a deep copy of the
string. So how does this fail?

More information about the webkit-reviews mailing list