[webkit-reviews] review granted: [Bug 19867] Inspector should support $(id) in the command line : [Attachment 22727] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 11 20:40:10 PDT 2008

Timothy Hatcher <timothy at hatcher.name> has granted Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 19867: Inspector should support $(id) in the command line

Attachment 22727: patch

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
+	 if (!inspectedWindow._inspectorCommandLineAPI)

You should put braces around that if block, since it is multiple lines.

Also you should improve the ChangeLog to call out what functions you are
changing and add more description before the Reviewed by line.

The < > and commas aren't needed for the bug list. Just put one per line.

Please file a bug about the profiler issues you mentioned.

More information about the webkit-reviews mailing list