[webkit-reviews] review denied: [Bug 20353] Use animation events to clear the highligted line effect : [Attachment 22739] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 11 19:02:48 PDT 2008
Timothy Hatcher <timothy at hatcher.name> has denied Anthony Ricaud
<rik24d at gmail.com>'s request for review:
Bug 20353: Use animation events to clear the highligted line effect
https://bugs.webkit.org/show_bug.cgi?id=20353
Attachment 22739: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=22739&action=edit
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
+ // Timeout to reset any animation still running
Can you improve that comment? Something about coalesced style updates?
+ line.style.webkitAnimationName = 'none';
We also don't use single quote strings. I would prefer using setProperty fore
these.
+ this.element.contentDocument.addEventListener("webkitAnimationEnd",
function (event) {
event.target.parentNode.removeStyleClass("webkit-highlighted-line");}, false);
Can you put the function on the prototype like _documentMouseDown.
+ line.style.webkitAnimationName = '';
That would make more sense as:
+ line.style.removeProperty("-webkit-animation-name")
More information about the webkit-reviews
mailing list