[webkit-reviews] review requested: [Bug 20351] <canvas> code needs fewer #ifdefs : [Attachment 22736] First pass at refactoring Pattern
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 11 18:10:10 PDT 2008
Eric Seidel <eric at webkit.org> has asked for review:
Bug 20351: <canvas> code needs fewer #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=20351
Attachment 22736: First pass at refactoring Pattern
https://bugs.webkit.org/attachment.cgi?id=22736&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/WebCore.xcodeproj/project.pbxproj | 16 ++-
WebCore/editing/DeleteButtonController.cpp | 10 +-
WebCore/html/CanvasPattern.cpp | 165 +-------------------
WebCore/html/CanvasPattern.h | 58 +------
WebCore/html/CanvasRenderingContext2D.cpp | 115 ++++-----------
WebCore/html/CanvasRenderingContext2D.h | 4 +-
WebCore/html/CanvasStyle.cpp | 165 ++++----------------
WebCore/html/HTMLCanvasElement.cpp | 44 -----
WebCore/html/HTMLCanvasElement.h | 24 +---
WebCore/loader/CachedImage.cpp | 24 ++--
WebCore/loader/CachedImage.h | 2 +-
WebCore/loader/FrameLoader.cpp | 6 +-
WebCore/loader/icon/IconRecord.cpp | 6 +-
WebCore/loader/icon/IconRecord.h | 2 +-
WebCore/platform/graphics/BitmapImage.h | 17 ++-
WebCore/platform/graphics/Color.cpp | 10 ++
WebCore/platform/graphics/Color.h | 2 +
WebCore/platform/graphics/GeneratedImage.h | 4 +
WebCore/platform/graphics/Gradient.cpp | 2 +-
WebCore/platform/graphics/Gradient.h | 5 -
WebCore/platform/graphics/GraphicsContext.h | 6 +-
WebCore/platform/graphics/Image.cpp | 7 +
WebCore/platform/graphics/Image.h | 20 ++--
WebCore/platform/graphics/ImageBuffer.h | 39 +-----
WebCore/platform/graphics/Pattern.cpp | 45 ++++++
WebCore/platform/graphics/Pattern.h | 62 ++++++++
.../graphics/cairo/GraphicsContextCairo.cpp | 17 ++
WebCore/platform/graphics/cairo/PatternCairo.cpp | 46 ++++++
WebCore/platform/graphics/cg/GraphicsContextCG.cpp | 33 ++++-
WebCore/platform/graphics/cg/ImageBufferCG.cpp | 8 +-
WebCore/platform/graphics/cg/PDFDocumentImage.h | 11 ++-
WebCore/platform/graphics/cg/PatternCG.cpp | 77 +++++++++
WebCore/platform/graphics/mac/ImageMac.mm | 12 +-
WebCore/rendering/RenderImage.cpp | 3 +-
WebCore/rendering/RenderLayer.cpp | 4 +-
WebCore/svg/graphics/SVGImage.cpp | 11 +--
WebCore/svg/graphics/SVGImage.h | 11 ++-
.../svg/graphics/cg/SVGPaintServerPatternCg.cpp | 2 +-
WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm | 2 +-
39 files changed, 482 insertions(+), 615 deletions(-)
More information about the webkit-reviews
mailing list