[webkit-reviews] review granted: [Bug 20346] Speed up the JavaScript syntax highlighter by generating the finders only once : [Attachment 22730] Proposed patch (ignoring whitespace changes)

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 20346: Speed up the JavaScript syntax highlighter by generating the finders
only once
https://bugs.webkit.org/show_bug.cgi?id=20346

Attachment 22730: Proposed patch (ignoring whitespace changes)
https://bugs.webkit.org/attachment.cgi?id=22730&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
+	 Removed, factoeed into syntaxHighlightJavascript as an inline
function.

Typo: factoeed

-	 var findSingleLineString =
generateFinder(/^"(?:[^"\\]|\\.)*"|^'([^'\\]|\\.)*'/, 0,
"webkit-javascript-string");
+	 var findSingleLineString =
generateFinder(/^"(?:[^"\\]|\\.)*"|^'([^'\\]|\\.)*'/, 0,
"webkit-javascript-string"); // "

Why this change?

r=me