[webkit-reviews] review granted: [Bug 20337] Implement CSS Animation and Transition Events : [Attachment 22712] now ready for review
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 8 20:48:32 PDT 2008
Timothy Hatcher <timothy at hatcher.name> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 20337: Implement CSS Animation and Transition Events
https://bugs.webkit.org/show_bug.cgi?id=20337
Attachment 22712: now ready for review
https://bugs.webkit.org/attachment.cgi?id=22712&action=edit
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
+ if (eventType == EventNames::webkitTransitionEndEvent) {
+ element->dispatchWebKitTransitionEvent(eventType, name, elapsedTime);
+ }
+ else {
+ element->dispatchWebKitAnimationEvent(eventType, name, elapsedTime);
+ }
The braces should be removed here.
Otherwise looks good, and Hyatt looked over it earlier.
More information about the webkit-reviews
mailing list