[webkit-reviews] review denied: [Bug 19867] Inspector should support $(id) in the command line : [Attachment 22127] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 7 09:05:08 PDT 2008


Timothy Hatcher <timothy at hatcher.name> has denied Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 19867: Inspector should support $(id) in the command line
https://bugs.webkit.org/show_bug.cgi?id=19867

Attachment 22127: patch
https://bugs.webkit.org/attachment.cgi?id=22127&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
You should rename testAPI to be more unique. Like __inspectorConsoleAPI.

Also it might be better to explicitly assign __inspectorConsoleAPI t the window
instead f using var.

So: window. __inspectorConsoleAPI = ...


More information about the webkit-reviews mailing list