[webkit-reviews] review denied: [Bug 20296] OpcodeStats don't build on linux : [Attachment 22676] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 6 05:20:32 PDT 2008


Eric Seidel <eric at webkit.org> has denied Csaba Osztrogonác
<oszi at inf.u-szeged.hu>'s request for review:
Bug 20296: OpcodeStats don't build on linux
https://bugs.webkit.org/show_bug.cgi?id=20296

Attachment 22676: proposed patch
https://bugs.webkit.org/attachment.cgi?id=22676&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Nah.  Better would be to either #define mergesort qsort

or to build some sort of abstraction for sorting "platformMergeSort()" and only
have the #ifdef in one place.

I'm surprised this hasn't been done already somewhere else?  You might try
searching the sources for HAVE(MERGE_SORT)


More information about the webkit-reviews mailing list