[webkit-reviews] review requested: [Bug 20294] Move more Frame methods into ScriptController : [Attachment 22673] Move more methods from Frame into ScriptController

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 6 01:20:57 PDT 2008


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 20294: Move more Frame methods into ScriptController
https://bugs.webkit.org/show_bug.cgi?id=20294

Attachment 22673: Move more methods from Frame into ScriptController
https://bugs.webkit.org/attachment.cgi?id=22673&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/GNUmakefile.am 			   |	1 +
 WebCore/WebCore.NPAPI.exp			   |	3 +-
 WebCore/WebCore.base.exp			   |	7 +-
 WebCore/WebCore.pro				   |	1 +
 WebCore/WebCore.vcproj/WebCore.vcproj		   |	4 +
 WebCore/WebCore.xcodeproj/project.pbxproj	   |	4 +
 WebCore/bindings/js/ScriptController.cpp	   |  136 ++++++++++++++++-
 WebCore/bindings/js/ScriptController.h 	   |   59 +++++++-
 WebCore/bindings/js/ScriptControllerGtk.cpp	   |   48 ++++++
 WebCore/bindings/js/ScriptControllerMac.mm	   |  168 +++++++++++++++++++++
 WebCore/bindings/js/ScriptControllerQt.cpp	   |   61 ++++++++
 WebCore/bindings/js/ScriptControllerWin.cpp	   |   45 ++++++
 WebCore/bindings/objc/DOM.mm			   |	3 +-
 WebCore/bindings/objc/DOMInternal.mm		   |	2 +-
 WebCore/bridge/jni/jni_jsobject.mm		   |	2 +-
 WebCore/html/HTMLAppletElement.cpp		   |   33 +---
 WebCore/html/HTMLAppletElement.h		   |   11 +--
 WebCore/html/HTMLEmbedElement.cpp		   |   40 +----
 WebCore/html/HTMLEmbedElement.h		   |   11 +--
 WebCore/html/HTMLObjectElement.cpp		   |   32 +----
 WebCore/html/HTMLObjectElement.h		   |	2 +-
 WebCore/html/HTMLPlugInElement.cpp		   |   72 ++++-----
 WebCore/html/HTMLPlugInElement.h		   |   12 +-
 WebCore/loader/FrameLoader.cpp 		   |   14 +-
 WebCore/page/Frame.cpp 			   |  125 ++--------------
 WebCore/page/Frame.h				   |   47 +------
 WebCore/page/FramePrivate.h			   |   42 +-----
 WebCore/page/gtk/FrameGtk.cpp			   |   30 ----
 WebCore/page/mac/FrameMac.mm			   |  141 ++---------------
 WebCore/page/qt/FrameQt.cpp			   |   96 ------------
 WebCore/page/win/FrameWin.cpp			   |   48 +------
 WebKit/mac/Plugins/WebBaseNetscapePluginView.mm   |	5 +-
 WebKit/mac/Plugins/WebPluginController.mm	   |	5 +-
 WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm |	6 +-
 WebKit/mac/WebView/WebFrame.mm 		   |	2 +-
 WebKit/mac/WebView/WebScriptDebugger.mm	   |   25 ++--
 WebKit/mac/WebView/WebView.mm			   |	2 +-
 37 files changed, 663 insertions(+), 682 deletions(-)


More information about the webkit-reviews mailing list